slyouts opened a new pull request #3555: NIFI-6391 Prevent excessive JMS connections URL: https://github.com/apache/nifi/pull/3555 Thank you for submitting a contribution to Apache NiFi. Excessive connections created when get/publish operations continually fail #### Description of PR PublishJMS repeatedly threw "ResourceAllocationException: too many open connections" after successive publish failures due to issues on the remote JMS Broker. The cause of this is the specification and implementation of the JMSConnectionFactoryProviderDefinition.resetConnectionFactory(ConnectionFactory cf) method. Setting the ConnectionFactory to null may well indeed close connections upon 'destruction', but it may take awhile for the GC to run; in the meantime, more connections are opened. The connections need to be manually closed rather than waiting for a GC. From AbstractJMSProcessor.onTrigger(), need to call worker.shutdown() prior to resetConnectionFactory(). Also, noticed some problems iwth the ConnectionFactoryProviderDefinition implementatoins wrt the resetConnectionFactory methods. The factory is nulled but never re-initialized but for onEnabled(); which will lead to a NPE at some point. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x ] Has your PR been rebased against the latest commit within the target branch (typically `master`)? - [x ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
