phrocker commented on a change in pull request #602: MINIFICPP-939: Install
deps up front on certian systems. Change cento…
URL: https://github.com/apache/nifi-minifi-cpp/pull/602#discussion_r298619358
##########
File path: extensions/librdkafka/CMakeLists.txt
##########
@@ -66,20 +67,6 @@ add_dependencies(minifi-rdkafka-extensions kafka-external)
include_directories(${ZLIB_INCLUDE_DIRS})
include_directories(${KAFKA_INCLUDE})
target_link_libraries (minifi-rdkafka-extensions ${BYPRODUCT})
-if (WIN32)
Review comment:
unnecessary cruft
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services