mcgilman commented on a change in pull request #3553: NIFI-5856: When exporting
a flow that references a Controller Service…
URL: https://github.com/apache/nifi/pull/3553#discussion_r299588726
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/NiFiServiceFacade.java
##########
@@ -2156,6 +2160,16 @@ ControllerServiceReferencingComponentsEntity
updateControllerServiceReferencingC
*/
void discoverCompatibleBundles(VersionedProcessGroup versionedGroup);
+ /**
+ * For any Controller Service that is found in the given Versioned Process
Group, if that Controller Service is not itself included in the Versioned
Process Groups,
+ * attempts to find an existing Controller Service that matches the
definition. If any is found, the component within the Versioned Process Group
is updated to point
+ * to the existing service.
+ *
+ * @param versionedFlowSnapshot the flow snapshot
+ * @param parentGroupId the ID of the Process Group from which the
Controller Services are inherited
+ */
+ void resolveInheritedControllerServices(VersionedFlowSnapshot
versionedFlowSnapshot, String parentGroupId);
Review comment:
Methods starting with `resolve*` are currently ignored with the service
facade lock. Can we please update it to ensure we are acquiring the appropriate
lock?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
