turcsanyip commented on a change in pull request #3570: Fix for NIFI-6422
URL: https://github.com/apache/nifi/pull/3570#discussion_r300370814
##########
File path:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BadTypeNameException.java
##########
@@ -0,0 +1,30 @@
+package org.apache.nifi.processors.gcp.bigquery;
+
+/**
+ * Exception thrown when a given type can't be transformed into a valid
BigQuery type.
+ * @author nicolas-delsaux
+ *
+ */
+public class BadTypeNameException extends RuntimeException {
Review comment:
It is a one time used class, so I think it is not needed to provide all the
overloaded constructors.
Furthermore, the exception class might be moved to BigQueryUtils as an inner
class, because it is only instantiated there and the exception is not caught
outside of the class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
