msharee9 commented on issue #604: MINIFICPP-926 Create nanofi tailfile processor for tailing file by configurable chunk size URL: https://github.com/apache/nifi-minifi-cpp/pull/604#issuecomment-509223047 > If I understand correctly this PR contains two modes (chunked and mixed) and does not yet contain the delimited mode. Do you plan on doing that in a separate PR? > I think if we want to include a mixed mode, both the delimiter and the maximum chunk size should be specifiable (now only the delimiter can be specified, the chunk size is fixed). > > Please also see my inline comments. @bakaid Yes, I plan to implement the delimited only mode in a separate PR that is MINIFICPP-927. I agree with your point to make chunk size configurable as well for the mixed mode.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
