avseq1234 commented on a change in pull request #3575: NIFI-6271, fix incoming
flowfile attributes don't copy into output flowfiles when Output Batch Size is
set
URL: https://github.com/apache/nifi/pull/3575#discussion_r301374996
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java
##########
@@ -312,12 +312,6 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
// If we've reached the batch size, send out
the flow files
if (outputBatchSize > 0 &&
resultSetFlowFiles.size() >= outputBatchSize) {
session.transfer(resultSetFlowFiles,
REL_SUCCESS);
- // Need to remove the original input file
if it exists
- if (fileToProcess != null) {
- session.remove(fileToProcess);
- fileToProcess = null;
- }
- session.commit();
Review comment:
Hi @ijokarumawak
I use the following snippet to create each new flowfile in the iteration.
` FlowFile resultSetFF = session.create();`
` resultSetFF = session.putAllAttributes(resultSetFF, inputFileAttrMap);`
I think it is more consistent than using ` fileToProcess == null` condition
to create new flowfile. I also add `input.flowfile.uuid` attribute of generated
resultSetFFs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
