apiri commented on a change in pull request #157: MINIFI-503 Update
commons-daemon version to 1.2.0.
URL: https://github.com/apache/nifi-minifi/pull/157#discussion_r301612041
##########
File path: minifi-assembly/pom.xml
##########
@@ -54,21 +65,20 @@ limitations under the License.
</then>
<else>
<echo message="Downloading Commons
Daemon Windows binaries." />
- <get
src="https://apache.claz.org/commons/daemon/binaries/windows/commons-daemon-1.1.0-bin-windows.zip";
dest="${java.io.tmpdir}/commons-daemon-1.1.0-bin-windows.zip"
skipexisting="true" />
+ <get
src="https://apache.claz.org/commons/daemon/binaries/windows/commons-daemon-${commons.daemon.version}-bin-windows.zip";
dest="${java.io.tmpdir}/commons-daemon-${commons.daemon.version}-bin-windows.zip"
skipexisting="true" />
Review comment:
I don't believe so and I think that is against ASF best practices.
Typically projects are instructed only to keep the latest version and then use
archive.apache.org for previous releases. Typically, the dist offerings are
only for review and initial seeding. This process seems to be reinforced as
per the containing page
(https://www.apache.org/dist/commons/daemon/binaries/windows/) urging the usage
of a mirror.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
