arpadboda commented on a change in pull request #604: MINIFICPP-926 Create nanofi tailfile processor for tailing file by configurable chunk size URL: https://github.com/apache/nifi-minifi-cpp/pull/604#discussion_r301570266
########## File path: nanofi/ecu/CMakeLists.txt ########## @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +cmake_minimum_required(VERSION 2.6) + +IF(POLICY CMP0048) + CMAKE_POLICY(SET CMP0048 OLD) +ENDIF(POLICY CMP0048) + +include_directories(/include) + +include(CheckCXXCompilerFlag) +if (WIN32) + if ((MSVC_VERSION GREATER "1900") OR (MSVC_VERSION EQUAL "1900")) + CHECK_CXX_COMPILER_FLAG("/std:c++14" _cpp_latest_flag_supported) + if (_cpp_latest_flag_supported) + add_compile_options("/std:c++14") Review comment: I hardly think we need 0y for C code :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
