apiri commented on issue #158: MINIFI-478 Fix broken OrderedProperties and OrderedPropertiesTest URL: https://github.com/apache/nifi-minifi/pull/158#issuecomment-510154059 Hi @shonzilla Code looks fine to support both 8 and 11. The implementation of the store0 method does actually change from 8->11 as seen in the the relevant sources: 8: http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/687fd7c7986d/src/share/classes/java/util/Properties.java#l832 11: https://github.com/unofficial-openjdk/openjdk/blob/jdk/jdk/src/java.base/share/classes/java/util/Properties.java#L926 It is my belief leaving keys() as is and then introducing the overridden entryset as provided by you should cover both. Does that thought process seem reasonable to you as well?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
