mattyb149 commented on issue #3543: NIFI-6388 Add dynamic relationships to the 
ExecuteScript processor.
URL: https://github.com/apache/nifi/pull/3543#issuecomment-510623347
 
 
   I'm waffling on whether we should have an explicit property (defaulted to 
false to retain behavior) to "Allow Custom Relationships". If it were set to 
true, then you'd apply the rules you have now (prefixed with `rel.`, e.g.), but 
if it's false, they are just treated as variables no matter the name.
   
   Is that overkill for some obscure edge case (namely variables with periods 
in it, which aren't very Groovy but are technically usable)? @alopresto do you 
have any thoughts on this? I could go either way, just wanted to talk through 
it first. Otherwise this LGTM :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to