kaHaleMaKai commented on issue #3543: NIFI-6388 Add dynamic relationships to 
the ExecuteScript processor.
URL: https://github.com/apache/nifi/pull/3543#issuecomment-510638209
 
 
   @mattyb149 Due to your suggestion, I have replaced the prefix `rel.` with 
`REL_` to honor the existing relationship naming (`REL_SUCCESS`, `REL_FAILURE`).
   
   Besides from potential collisions with existing properties, the introduced 
variable `relationships` in the script context might already be in used by some 
scripts for whatever reason. Collisions are even more likely than.
   
   I follow your suggestion and would like to add a flag for activating dynamic 
relationships (defaulting to false) to _opt-in_ into dynamic relationships. We 
could then deprecate the old behaviour and competely remove it (including the 
flag, if you like) in let's say NiFi 2.0. From then, the `REL_.*` named 
properties would always yield dynamic relationships no matter what. 
   
   Thanks for naming the issue, I hadn't thought of that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to