bakaid opened a new pull request #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient bugs, created tests f… URL: https://github.com/apache/nifi-minifi-cpp/pull/610 …or ListenHTTP This fixes the following ListenHTTP issues: - HTTPS did not work - SSL Minimum Version enforcement caused hanging client and leaked fds in the server - HEAD requests were not served properly - random port did not work with HTTPS This fixes the following HTTPClient issues: - PUT did not work - HEAD did not work - POST using setPostFields was a potential use-after-free - cURL SSL backend was erroneously deduced - header parsing was faulty This adds the following features: - logging for CivetWeb - logging for cURL - tests for ListenHTTP Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
