bakaid commented on a change in pull request #612: MINIFICPP-854: Capture RTSP
Frame
URL: https://github.com/apache/nifi-minifi-cpp/pull/612#discussion_r304342503
##########
File path: extensions/opencv/CaptureRTSPFrame.cpp
##########
@@ -155,12 +172,12 @@ void CaptureRTSPFrame::onTrigger(const
std::shared_ptr<core::ProcessContext> &co
}
frame.release();
-
}
void CaptureRTSPFrame::notifyStop() {
// Release the Capture reference and free up resources.
video_capture_.release();
+ unsetenv("OPENCV_FFMPEG_CAPTURE_OPTIONS");
Review comment:
@nghiaxlee Now that I think of this, we should not unset this at all. If
there are two instances of this processor running, and one is stopped through
C2, it will unset it for the other processor as well which could cause issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services