phrocker commented on a change in pull request #613: Minificpp 927 Nanofi 
tailfile delimited processor
URL: https://github.com/apache/nifi-minifi-cpp/pull/613#discussion_r304481364
 
 

 ##########
 File path: nanofi/CMakeLists.txt
 ##########
 @@ -33,9 +33,11 @@ else()
 include_directories(../libminifi/opsys/posix)
 endif()
 
-file(GLOB NANOFI_SOURCES  "src/api/*.cpp" "src/core/*.c*" "src/cxx/*.cpp" 
"src/sitetosite/*.c*")
+file(GLOB NANOFI_SOURCES  "src/api/*.cpp" "src/api/*.c" "src/core/*.c*" 
"src/cxx/*.cpp" "src/sitetosite/*.c*")
 
 Review comment:
   @msharee9  Hey, I know we discussed this ticket 
   https://issues.apache.org/jira/browse/MINIFICPP-666, but I never set the 
version. If we play our cards right in 0.7.0 and 0.8.0 I think we can very 
quickly decouple these projects. There are other tickets in this release that 
go toward that ( removing instance ) but @arpadboda's comment is a key reminder 
that we need to do that. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to