phrocker edited a comment on issue #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-512872605 @arpadboda https://github.com/apache/nifi-minifi-cpp#running Running it in other ways would constitute a response that we advise running it in that way. Happy to see a PR if you think that should be clarified. I don't want to preclude others from running it a way they see fit, but the processor is a specialized case. The documentation that @nghiaxlee writes here should make it clear we expect that environment variable set. It is not the onus of the main readme, but rather in his processor documentation. That also highlights the point that the processors.md should be updated, @nghiaxlee since you have an exceptional case that warrants commenting. The point about NaNoFi is a good point. https://issues.apache.org/jira/browse/MINIFICPP-742 should clarify some of this. NaNoFi is a library not a set of processors, so "configuring MiNiFi processors" has the same issue that it must be clearly documented. If an implementation arises that uses OpenCV, then that implementation is free to set the environment variable; however, my last comment was to explore other options. I've presented an option : using the shell script. Happy to hear other options to address that concern, but I currently use OpenCV in such a way with an http rtsp_transport on my local network network. My scripts ( which do a lot more with TF ) use an exported environment variable. The alternative is to check and not override. That may be safe -- but I think that is up to @nghiaxlee to evaluate and do a risk assessment. OpenCV is commonly used with python processors ( I know of implementations being built in such a way ). Will this initializer also ensure that anything set for those instances isn't also impacting/overriding this in a thread safe way? I'm totally cool if my concerns aren't valid -- that is possible too, but would love to hear @nghiaxlee's take on that.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
