phrocker commented on a change in pull request #614: MINIFICPP-732 - Add
property to expose librdkafka "debug" values for …
URL: https://github.com/apache/nifi-minifi-cpp/pull/614#discussion_r305096284
##########
File path: extensions/librdkafka/PublishKafka.cpp
##########
@@ -129,9 +131,16 @@ bool PublishKafka::configureNewConnection(const
std::shared_ptr<KafkaConnection>
auto key = conn->getKey();
+ if (context->getProperty(DebugContexts.getName(), value) && !value.empty()) {
+ rd_kafka_conf_set(conf_, "debug", value.c_str(), errstr, sizeof(errstr));
Review comment:
If we can'd ultimately do allow able values ( i commented above ) -- then
that means we need to rely on this CSV. Very little validation is performed
here -- so I presume librdkafka does that validation. In those cases do you get
an immediate response or must we wait until data is supplied and sent through
Kafka?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services