bakaid commented on a change in pull request #610: MINIFICPP-814 - Fixed 
ListenHTTP and HTTPClient bugs, created tests f…
URL: https://github.com/apache/nifi-minifi-cpp/pull/610#discussion_r305252996
 
 

 ##########
 File path: libminifi/include/utils/HTTPClient.h
 ##########
 @@ -66,37 +69,89 @@ struct HTTPReadCallback {
   }
 };
 
+enum class SSLVersion : uint8_t {
+  SSLv2,
+  SSLv3,
+  TLSv1_0,
+  TLSv1_1,
+  TLSv1_2,
+};
+
 struct HTTPHeaderResponse {
  public:
-
   HTTPHeaderResponse(int max)
-      : max_tokens_(max) {
+   : max_tokens_(max)
+   , parsed(false) {
   }
 
-  void append(const std::string &header) {
+  DEPRECATED void append(const std::string &header) {
 
 Review comment:
   Sure, will do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to