nghiaxlee commented on a change in pull request #614: MINIFICPP-732 - Add
property to expose librdkafka "debug" values for …
URL: https://github.com/apache/nifi-minifi-cpp/pull/614#discussion_r305281157
##########
File path: extensions/librdkafka/PublishKafka.cpp
##########
@@ -79,6 +79,7 @@ core::Property PublishKafka::KerberosKeytabPath("Kerberos
Keytab Path",
core::Property PublishKafka::MessageKeyField("Message Key Field", "The name of
a field in the Input Records that should be used as the Key for the Kafka
message.\n"
"Supports Expression Language:
true (will be evaluated using flow file attributes)",
"");
+core::Property PublishKafka::DebugContexts("Debug contexts", "A
comma-separated list of debug contexts to enable. Including: generic, broker,
topic, metadata, feature, queue, msg, protocol, cgrp, security, fetch,
interceptor, plugin, consumer, admin, eos, all", "");
Review comment:
I assume we are talking about 'withAllowableValues' in PropertyBuilder. In
'LogAttribute.cpp', there is a set of allowable values ("debug", "info", etc),
though only one of them can be set at a time. In this case, "msg,topic,broker",
"topic,msg" or "broker,msg" are all valid values. Thus, I don't understand how
can allowable values can check that. If I misunderstand anything, I would love
to hear your correction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
