arpadboda commented on issue #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-513171708 @phrocker : according to the documentation we recommend (as we don't provide any other options) the script to start MiNiFi, but don't highlight that doing any other way might end up in unexpected behaviour. Which is fine as it shoudn't in my opinion. Let's just mention our own testing, which also starts the binary directly, bypassing the script. Going ahead with this approach, all of opencv tests are going to set (and hopefully unset) env vars, even in case of assertions (failures)? The above and the NaNoFi case I think are not issues we need to resolve, just consequences of violating some best practices and principals: what belongs together should be handled as a unit, being responsible to work independently from the environment. Don't get me wrong, I agree that the concerns you and @bakaid raised on being thread-safe when setting the env var is valid and should be addressed. What I would like to say that this is something the processor is responsible for, so it should be handled by that, otherwise we inject a hidden dependencies like the ones we listed above.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
