jtstorck commented on a change in pull request #3404: NIFI-5176 Java 11 Build
Compatibilty
URL: https://github.com/apache/nifi/pull/3404#discussion_r305982721
##########
File path: nifi-commons/nifi-site-to-site-client/pom.xml
##########
@@ -61,14 +61,14 @@
<version>1.10.0-SNAPSHOT</version>
</dependency>
<dependency>
- <groupId>org.apache.httpcomponents</groupId>
- <artifactId>httpclient</artifactId>
- <version>4.5.5</version>
+ <groupId>org.apache.httpcomponents.client5</groupId>
+ <artifactId>httpclient5</artifactId>
+ <version>5.0-beta4</version>
Review comment:
It may be best to move this dependency to the jigsaw profile in this module,
so that when built in Java 8 it uses version 4.5.5. Any thoughts or
preferences here? There are a couple ways to set up the dependencies to
accomplish this, but they don't seem very maintenance-friendly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
