mgaido91 commented on a change in pull request #3600: NIFI-6420 Controller
Service references not properly tracked if multiple references from same
component
URL: https://github.com/apache/nifi/pull/3600#discussion_r306984219
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/processor/StandardSchedulingContext.java
##########
@@ -65,7 +66,7 @@ public void leaseControllerService(final String identifier) {
+
serviceNode.getProxiedControllerService().getIdentifier() + " is in the process
of validating its configuration");
}
- serviceNode.addReference(processorNode);
+ serviceNode.addReference(processorNode, LEASE_TAG);
Review comment:
can you have a test case for this in order to ensure that we are not leaking
this reference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
