arpadboda commented on a change in pull request #617: Minificpp 897
URL: https://github.com/apache/nifi-minifi-cpp/pull/617#discussion_r307691664
##########
File path: extensions/libmodbus/CMakeLists.txt
##########
@@ -0,0 +1,13 @@
+include(${CMAKE_SOURCE_DIR}/extensions/ExtensionHeader.txt)
+
+include(ExternalProject)
+
+ExternalProject_Add(
+ libmodbus_external
+ PREFIX ${LIBMODBUS_ROOT}
+ GIT_REPOSITORY "https://github.com/stephane/libmodbus.git";
Review comment:
Can you specify a tag or at least a commit here to make sure our builds
doesn't get accidentally broken by changes in this repo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
