[
https://issues.apache.org/jira/browse/NIFI-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893910#comment-16893910
]
Mark Payne commented on NIFI-6433:
----------------------------------
[~jmark99] thanks for the PR. I reviewed the code and all looked good. Tested
and things still seem to work as they did. However, it's worth noting that even
though the repo is now properly supporting this, the web requests to get status
history do not accept any parameters for the start/end date or preferred data
points. That may be why those parameters got ignored to begin with, since they
aren't used by the REST endpoints. That being said, this does at least cause
the backend to handle it correctly, and we can add parameters to the REST
Endpoints in the future to pass these flags along, so I went ahead and merged
to master. Thanks!
> Update getStatusHistory to honor filter parameters
> --------------------------------------------------
>
> Key: NIFI-6433
> URL: https://issues.apache.org/jira/browse/NIFI-6433
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.9.2
> Reporter: Mark Owens
> Assignee: Mark Owens
> Priority: Minor
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This modification updates the getStatusHistory methods of
> VolatileComponentStatusRepository to utilize the start, end, and
> preferredDataPoints parameters when retrieving status histories.
> When calling the various getXXXStatusHistory methods of
> VolatileComponentStatusRepository, they are all passed start, end, and
> preferredDataPoints values to allow the filtering of histories according to
> the provided parameters. But the follow-on method calls ignore those values
> completely. This ticket updates those methods to honor the parameters and
> filter the returned Dates accordingly.
> Although for VolatileComponentStatusRepository the timestamps buffer is
> rather small, it seems better that the parameters be utilized rather than
> being silently ignored. This was found during work on a task where I only
> needed a subset of the buffer returned.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
