phrocker commented on issue #617: Minificpp 897
URL: https://github.com/apache/nifi-minifi-cpp/pull/617#issuecomment-515529548
 
 
   @am-c-p-p with your last comment I'm good with this; however, I don't see 
any thing being compiled with this.  I also appreciate @arpadboda 's comment. 
Can you add some readme to this extension as to why these files are needed for 
this extension? I think it's fair that the purview of an extension allows it to 
use a process, but a readme of why would be helpful.
   
   Do you intend to submit a separate PR for follow on code to this or will you 
update this one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to