mgaido91 commented on a change in pull request #3613: NIFI-6502 Add padLeft()
and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r308597899
##########
File path:
nifi-commons/nifi-record-path/src/test/java/org/apache/nifi/record/path/TestRecordPath.java
##########
@@ -1580,6 +1580,38 @@ public void testBase64Decode() {
});
}
+ @Test
+ public void testPadLeft() {
+ final List<RecordField> fields = new ArrayList<>();
+ fields.add(new RecordField("someString",
RecordFieldType.STRING.getDataType()));
+ final RecordSchema schema = new SimpleRecordSchema(fields);
+
+ final Map<String, Object> values = new HashMap<>();
+ values.put("someString", "MyString");
+
+ final Record record = new MapRecord(schema, values);
+
+ assertEquals("##MyString", RecordPath.compile("padLeft(/someString,
10, '#')").evaluate(record).getSelectedFields().findFirst().get().getValue());
+ assertEquals("__MyString", RecordPath.compile("padLeft(/someString,
10)").evaluate(record).getSelectedFields().findFirst().get().getValue());
+ assertEquals("MyString", RecordPath.compile("padLeft(/someString,
3)").evaluate(record).getSelectedFields().findFirst().get().getValue());
Review comment:
please add tests with null input strings, with empty input strings, with
invalid inputs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
