phrocker commented on a change in pull request #624: CEM-462 CEM-417 Fixed.
URL: https://github.com/apache/nifi-minifi-cpp/pull/624#discussion_r312918712
 
 

 ##########
 File path: extensions/windows-event-log/ConsumeWindowsEventLog.h
 ##########
 @@ -97,6 +98,7 @@ class ConsumeWindowsEventLog : public core::Processor
   std::shared_ptr<core::ProcessSessionFactory> sessionFactory_;
   bool renderXML_{};
   MSXML2::IXMLDOMDocumentPtr xmlDoc_;
+  std::atomic<bool> processorStopped_ = false;
 
 Review comment:
   The name here is odd -- processorStopped implies that the processor was 
stopped but if it's not started it is not stopped? The nomenclature seems as 
though it could lead to confusion. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to