RynoRn commented on issue #211: NIFIREG-295 Add support for proxying via Apache 
Knox
URL: https://github.com/apache/nifi-registry/pull/211#issuecomment-520446879
 
 
   I've looked through the changes and I have found a few things.
   
   Please note that there are two ways to run the front-end application. Please 
make sure to test the application both way.
   
   The first [1] is to run a `maven` build and then start the resulted 
assembly. In this case the application will start on 
`http://localhost:18080/nifi-registry/`.
   
   The second way [2] is to start the backend API with the `maven` build but 
build and run the front-end separately from the `nifi-registry-web-ui`. In this 
case the front-end will pop up on `http://localhost:18081`.
   
   Problems I found:
   - Please double check if the front-end unit tests are working properly. I 
see **53 FAILED** test when I run `npm run test`. For example this part is 
probably broken: 
https://github.com/apache/nifi-registry/pull/211/files#diff-93f434be0ca46a3da816f4f2bc23fd04R185
   - I see an error on the console if I run the app with a full build [1]
   - When I refresh the application on a deep link it fails to load. E.g.: 
http://localhost:18081/explorer/grid-list. I'm not sure if this problem was 
introduced here or not. If not, feel free to ignore but would be a nice 
addition to fix.
   - I see an error on the console when running with the full maven build [1]: 
`Error POST http://localhost:18080/nifi-registry-api/access/token/kerberos 409 
(Conflict)`
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to