bakaid commented on a change in pull request #613: Minificpp 927 Nanofi tailfile delimited processor URL: https://github.com/apache/nifi-minifi-cpp/pull/613#discussion_r313325605
########## File path: nanofi/include/api/ecu.h ########## @@ -0,0 +1,89 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +*/ + +#ifndef NANOFI_INCLUDE_API_ECU_H_ +#define NANOFI_INCLUDE_API_ECU_H_ + +#include <signal.h> +#include "api/nanofi.h" +#include "uthash.h" +#include "utlist.h" + +#ifdef __cplusplus +extern "C" { +#endif + + +typedef struct processor_params { + char uuid_str[37]; //key + struct flow_file_list * ff_list; + uint64_t curr_offset; + UT_hash_handle hh; +} processor_params; + +extern processor_params * procparams; Review comment: Having this is a global variable is - NOT thread-safe (you can't do anything that would write the hash table with anything else in parallel), meaning you have to be very careful when using ECUs in multiple threads - I am not sure how this would scale These are acceptable for now, but should be documented. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
