rfellows commented on a change in pull request #211: NIFIREG-295 Add support 
for proxying via Apache Knox
URL: https://github.com/apache/nifi-registry/pull/211#discussion_r313417267
 
 

 ##########
 File path: 
nifi-registry-core/nifi-registry-web-ui/src/main/webapp/template.dev.html
 ##########
 @@ -19,7 +19,7 @@
 <html>
 <head>
     <title>NiFi Registry</title>
-    <base href="/">
+    <base href="./">
 
 Review comment:
   This template is only used in UI-dev-mode. I don't think one would ever 
configure dev mode and knox together since dev mode is just the front end and 
proxies requests to a running back-end.
   
   This change breaks dev-mode when you try to navigate directly (or refresh) 
to `http://localhost:18081/explorer/grid-list`
   
   I don't think this change is needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to