kevdoran commented on a change in pull request #212: NIFIREG-300 Added nifi-registry-revision modules containg NiFi's Revi… URL: https://github.com/apache/nifi-registry/pull/212#discussion_r313471271
########## File path: nifi-registry-core/nifi-registry-revision/nifi-registry-revision-common/src/main/java/org/apache/nifi/registry/revision/standard/RevisionComparator.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.registry.revision.standard; + +import org.apache.nifi.registry.revision.api.Revision; + +import java.util.Comparator; + +public class RevisionComparator implements Comparator<Revision> { + + @Override + public int compare(final Revision o1, final Revision o2) { + final int entityComparison = o1.getEntityId().compareTo(o2.getEntityId()); + if (entityComparison != 0) { + return entityComparison; + } + + final int clientComparison = o1.getClientId().compareTo(o2.getClientId()); Review comment: clientId is an optional field, right? can this line generate a NPE? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
