nghiaxlee commented on a change in pull request #627: MINIFICPP-989 - Motion detect for a set of captured frames URL: https://github.com/apache/nifi-minifi-cpp/pull/627#discussion_r314685488
########## File path: extensions/opencv/FrameIO.h ########## @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef NIFI_MINIFI_CPP_FRAMEIO_H +#define NIFI_MINIFI_CPP_FRAMEIO_H + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace processors { + +class FrameWriteCallback : public OutputStreamCallback { + public: + explicit FrameWriteCallback(cv::Mat image_mat, std::string image_encoding_) + // TODO - Nghia: Check std::move(img_mat). + : image_mat_(std::move(image_mat)), image_encoding_(image_encoding_) { + } + ~FrameWriteCallback() override = default; + + int64_t process(std::shared_ptr<io::BaseStream> stream) override { + int64_t ret = 0; + imencode(image_encoding_, image_mat_, image_buf_); + ret = stream->write(image_buf_.data(), image_buf_.size()); + return ret; + } + + private: + std::vector<uchar> image_buf_; + cv::Mat image_mat_; + std::string image_encoding_; +}; + +class FrameReadCallback : public InputStreamCallback { + public: + explicit FrameReadCallback(cv::Mat *image_mat) + : image_mat_(image_mat) { + } + ~FrameReadCallback() override = default; + + int64_t process(std::shared_ptr<io::BaseStream> stream) override { + int64_t ret = 0; + image_buf_.resize(stream->getSize()); + ret = stream->read(image_buf_.data(), static_cast<int>(stream->getSize())); + if (ret != stream->getSize()) { + throw std::runtime_error("ImageReadCallback failed to fully read flow file input stream"); + } + *image_mat_ = cv::imdecode(image_buf_, -1); Review comment: It will be released outside onTrigger scope. The pointer points to a cv::Mat object in onTrigger, and the CallBack also in onTrigger. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
