adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft()
and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r314943111
##########
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##########
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
- public static String padLeft(final String source, int length, char
padding) {
- if (source != null) {
+ public static String padLeft(final String source, int length, String
padding) {
Review comment:
Hello Mike, This is inspired on both
[commons-lang3](https://github.com/apache/commons-lang/blob/d5ffc4dde6236ed5afbedfeb333bb87dceb3fe7a/src/main/java/org/apache/commons/lang3/StringUtils.java#L5247)
and the previous implementation, which didn't allow String as padding.
What do you think about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
