ijokarumawak commented on issue #3621: NIFI-6509 - Date related issue in unit 
test VolatileComponentStatusRe…
URL: https://github.com/apache/nifi/pull/3621#issuecomment-522834404
 
 
   Hi @tpalfy, thanks for sending the PR! Another JIRA NIFI-6508 and its patch 
were submitted before this PR, so I merged NIFI-6508 to address the timezone 
issue at the test. Please take a look at this commit 
https://github.com/apache/nifi/commit/00f0f84856226ac39c92807c01945bb017e99bb4
   
   I noticed your PR addresses the issue as well as does some refactoring to 
improve code readability. I like more self-descriptive variable naming like you 
did in the PR. Now the PR has conflict, if you can address conflict, I'm happy 
to keep reviewing so that your change can also be merged. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to