rfellows commented on a change in pull request #3606: [WIP] Nifi 6282
URL: https://github.com/apache/nifi/pull/3606#discussion_r317626487
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##########
@@ -1756,6 +1792,16 @@
$('#parameter-dialog').modal();
+ $('#parameter-value-field').keydown(function () {
+ var sensitiveInput = $(this);
+ if (sensitiveInput.hasClass('sensitive')) {
Review comment:
What is the true intent of this `sensitive` class? It seems like it is used
to determine if a sensitive parameter value has changed. If that is the case I
would recommend renaming it to be more explicit. Just by reading it as-is, my
first impression is that it it used to determine if a parameter is sensitive or
not.
I suggest something like `sensitive-unchanged` or `sensitive-not-modified`.
I'm just thinking of future debugging sessions and getting confused as to what
it really is used for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
