phrocker commented on a change in pull request #630: MINIFICPP-1006: minor
updates for jni building using win build & correct artifact naming
URL: https://github.com/apache/nifi-minifi-cpp/pull/630#discussion_r317793803
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -126,22 +122,19 @@ ConsumeWindowsEventLog::ConsumeWindowsEventLog(const
std::string& name, utils::I
}
ConsumeWindowsEventLog::~ConsumeWindowsEventLog() {
- if (xmlDoc_) {
- xmlDoc_.Release();
- }
- CoUninitialize();
}
void ConsumeWindowsEventLog::initialize() {
//! Set the supported properties
- setSupportedProperties({Channel, Query, RenderFormatXML, MaxBufferSize,
InactiveDurationToReconnect, IdentifierMatcher, IdentifierFunction });
+ setSupportedProperties({Channel, Query, MaxBufferSize,
InactiveDurationToReconnect, IdentifierMatcher, IdentifierFunction,
ResolveAsAttributes });
//! Set the supported relationships
setSupportedRelationships({Success});
}
void ConsumeWindowsEventLog::onSchedule(const
std::shared_ptr<core::ProcessContext> &context, const
std::shared_ptr<core::ProcessSessionFactory> &sessionFactory) {
context->getProperty(IdentifierMatcher.getName(), regex_);
+ context->getProperty(ResolveAsAttributes.getName(),
resolve_as_attributes_);
Review comment:
It's multiple tickets per the commit, but it's a default value, so should
be safe if removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
