alopresto commented on a change in pull request #3672: NIFI-6363 Additional
Sensitive Property Providers
URL: https://github.com/apache/nifi/pull/3672#discussion_r318126079
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/main/java/org/apache/nifi/properties/sensitive/ExternalProperties.java
##########
@@ -14,10 +14,21 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.nifi.properties;
+package org.apache.nifi.properties.sensitive;
-public interface SensitivePropertyProviderFactory {
+/**
+ * ExternalProperties is an interface for reading external values by name.
+ *
+ */
+public interface ExternalProperties {
- SensitivePropertyProvider getProvider();
+ /**
+ * Read an external property by name.
+ *
+ * @param name the name or key of the external property
+ * @return external property value, as a string
+ */
+ String get(String name);
+ String get(String name, String missing);
Review comment:
Missing Javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
