joewitt commented on a change in pull request #3674: Nifi 6583 URL: https://github.com/apache/nifi/pull/3674#discussion_r318265631
########## File path: nifi-nar-bundles/nifi-metrics-reporting-bundle/nifi-metrics-reporting-task/src/main/java/org/apache/nifi/metrics/reporting/reporter/service/AzureLogAnalysticsMetricReporterService.java ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.metrics.reporting.reporter.service; + +import com.codahale.metrics.MetricFilter; +import com.codahale.metrics.MetricRegistry; +import com.codahale.metrics.ScheduledReporter; +import org.apache.nifi.annotation.documentation.CapabilityDescription; +import org.apache.nifi.annotation.documentation.Tags; +import org.apache.nifi.annotation.lifecycle.OnDisabled; +import org.apache.nifi.annotation.lifecycle.OnEnabled; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.controller.AbstractControllerService; +import org.apache.nifi.controller.ConfigurationContext; +import org.apache.nifi.expression.ExpressionLanguageScope; +import org.apache.nifi.metrics.reporting.task.MetricsReportingTask; +import org.apache.nifi.processor.util.StandardValidators; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.concurrent.TimeUnit; + +/** + * A controller service that provides metric reporters for azure log analystics, can be used by {@link MetricsReportingTask}. + * + * @author Seokwon J. Yang + */ +@Tags({"metrics", "reporting", "azure", "loganalystics"}) +@CapabilityDescription("A controller service that provides metric reporters for azure log analystics. " + + "Used by MetricsReportingTask.") +public class AzureLogAnalysticsMetricReporterService extends AbstractControllerService implements MetricReporterService { + + /** + * Azure Log Anaystics Workspace ID + */ + public static final PropertyDescriptor AZ_WORKSPACE_ID = new PropertyDescriptor.Builder() + .name("Azure Log Anaystics Workspace Id") Review comment: name more commonly these days is less 'human readable' and more 'long term naming' centric. For instance 'azure.log.analytics.workspace.id' then the Display Name value can be the human readable and somewhat changeable over time value. As you have it is technically ok but consider if using the human readable form that it is effective stuck with that forever. Also watch out for the mispelling here in analytics as a good example to fix and why we'd avoid human readable generally for name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
