sjyang18 commented on a change in pull request #3674: Nifi 6583
URL: https://github.com/apache/nifi/pull/3674#discussion_r318334218
##########
File path:
nifi-nar-bundles/nifi-metrics-reporting-bundle/nifi-metrics-reporting-task/pom.xml
##########
@@ -35,11 +35,32 @@
<version>1.10.0-SNAPSHOT</version>
<scope>provided</scope>
</dependency>
+ <dependency>
Review comment:
We initially tried to forward the logs generated from existing
MetricReportingTask available in this nar to Azure WS. Later, we also found
that we also want to capture nifi-metrics.
Instead of creating a new nar, I think that reusing existing service-api,
reporting task and adding a new controller service with additional reporting
tasks make sense to me.
I have also updated
nifi-metrics-reporting-nar/src/main/resources/META-INF/NOTICE to mention CDDL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
