arpadboda commented on a change in pull request #637: MINIFICPP-1020 - PutFile fails to create empty files URL: https://github.com/apache/nifi-minifi-cpp/pull/637#discussion_r319402435
########## File path: CPPLINT.cfg ########## @@ -0,0 +1,2 @@ +set noparent +filter=-runtime/references Review comment: ``` Is this a non-const reference? If so, make const or use a pointer: std::vector<char>& data [runtime/references] [2] ``` I think this hardly makes sense, passing a container by reference is much better than passing as a raw pointer. Moreover it's inconsistent as well, in case of lambdas it allows you to either capture by reference or have reference arguments. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
