bakaid commented on a change in pull request #639: MINFICPP-1005 - Disable
<TLSv1.2 for incoming and <TLSv1.0 for outgoi…
URL: https://github.com/apache/nifi-minifi-cpp/pull/639#discussion_r319534998
##########
File path: extensions/civetweb/processors/ListenHTTP.cpp
##########
@@ -182,21 +182,12 @@ void ListenHTTP::onSchedule(core::ProcessContext
*context, core::ProcessSessionF
options.emplace_back("yes");
}
- if (sslMinVer == "SSL2") {
- options.emplace_back("ssl_protocol_version");
- options.emplace_back(std::to_string(0));
- } else if (sslMinVer == "SSL3") {
- options.emplace_back("ssl_protocol_version");
- options.emplace_back(std::to_string(1));
- } else if (sslMinVer == "TLS1.0") {
- options.emplace_back("ssl_protocol_version");
- options.emplace_back(std::to_string(2));
- } else if (sslMinVer == "TLS1.1") {
- options.emplace_back("ssl_protocol_version");
- options.emplace_back(std::to_string(3));
- } else {
+ if (sslMinVer == "TLS1.2") {
options.emplace_back("ssl_protocol_version");
options.emplace_back(std::to_string(4));
+ } else {
+ logger_->log_error("Invalid SSL Minimum Version specified!");
Review comment:
Fair point, I will change this to an exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
