arpadboda commented on a change in pull request #615: MINIFICPP-963 - Zero byte
(no content) flow files cannot be received …
URL: https://github.com/apache/nifi-minifi-cpp/pull/615#discussion_r319972909
##########
File path: docker/test/integration/minifi/__init__.py
##########
@@ -211,7 +211,7 @@ def build_image(self, dockerfile, context_files):
with tarfile.open(mode='w', fileobj=docker_context_buffer) as
docker_context:
dockerfile_info = tarfile.TarInfo('Dockerfile')
- dockerfile_info.size = len(conf_dockerfile_buffer.getvalue())
+ dockerfile_info.size =
conf_dockerfile_buffer.getbuffer().nbytes
Review comment:
Just avoiding copy and making this clear.
Dockerverify.sh creates a python3 virtual env, so I think this should be
fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
