ottobackwards commented on a change in pull request #3612: NIFI-6486 Add option
to use built-in retry mechanism in AWS processors
URL: https://github.com/apache/nifi/pull/3612#discussion_r319989749
##########
File path:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/DeleteDynamoDB.java
##########
@@ -75,7 +75,9 @@
Arrays.asList(TABLE, HASH_KEY_NAME, RANGE_KEY_NAME,
HASH_KEY_VALUE, RANGE_KEY_VALUE,
HASH_KEY_VALUE_TYPE, RANGE_KEY_VALUE_TYPE, BATCH_SIZE, REGION,
ACCESS_KEY, SECRET_KEY,
CREDENTIALS_FILE, AWS_CREDENTIALS_PROVIDER_SERVICE, TIMEOUT,
SSL_CONTEXT_SERVICE,
- PROXY_CONFIGURATION_SERVICE, PROXY_HOST, PROXY_HOST_PORT,
PROXY_USERNAME, PROXY_PASSWORD));
+ PROXY_CONFIGURATION_SERVICE, PROXY_HOST, PROXY_HOST_PORT,
PROXY_USERNAME, PROXY_PASSWORD,
Review comment:
That kind of refactor would probably be beyond the scope for this PR, maybe
you can enter another jira for that work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
