dtrodrigues commented on a change in pull request #640: MINIFICPP-915 - add
util to list all of a directory without callback
URL: https://github.com/apache/nifi-minifi-cpp/pull/640#discussion_r320052231
##########
File path: libminifi/include/utils/file/FileUtils.h
##########
@@ -402,6 +403,16 @@ class FileUtils {
#endif
}
+ static void list_dir_all(std::vector<std::pair<std::string, std::string>>
&fileList, const std::string& dir,
Review comment:
No big reason -- I figured it might allow a user to pass in a vector with
entries already in it so list_dir_all could be called multiple times on
different directories. I can definitely have it return a vector instead if
that's preferred.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
