phrocker commented on a change in pull request #615: MINIFICPP-963 - Zero byte
(no content) flow files cannot be received …
URL: https://github.com/apache/nifi-minifi-cpp/pull/615#discussion_r321301867
##########
File path: extensions/http-curl/sitetosite/HTTPProtocol.cpp
##########
@@ -297,23 +305,9 @@ void HttpSiteToSiteClient::closeTransaction(const
std::string &transactionID) {
}
void HttpSiteToSiteClient::deleteTransaction(std::string transactionID) {
- std::shared_ptr<Transaction> transaction = NULL;
-
- std::map<std::string, std::shared_ptr<Transaction> >::iterator it =
this->known_transactions_.find(transactionID);
-
- if (it == known_transactions_.end()) {
- return;
- } else {
- transaction = it->second;
- }
-
- std::string append_str;
- logger_->log_debug("Site2Site delete transaction %s",
transaction->getUUIDStr());
-
Review comment:
Good stuff. This should have been done when SiteToSiteClient was broken out
into a base class but never was, so thanks for catching this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
