tpalfy commented on a change in pull request #3724: NIFI-6640 - UNION/CHOICE types not handled correctly URL: https://github.com/apache/nifi/pull/3724#discussion_r324275668
########## File path: nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/java/org/apache/nifi/avro/TestAvroTypeUtil.java ########## @@ -587,4 +588,49 @@ public void testListAndMapConversion() { assertNotNull(((Record)inner).get("Message")); } } + + @Test + public void testConvertToAvroObjectWhenFloatVSUnion_INT_FLOAT_ThenReturnFloat() { Review comment: These two tests can be done more elegantly. Also need to add a version where INT is expected (and maybe test some other types). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services