granthenke commented on a change in pull request #3732: NIFI-6662: Adding Kudu Lookup Service URL: https://github.com/apache/nifi/pull/3732#discussion_r325452193
########## File path: nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-controller-service/pom.xml ########## @@ -91,4 +107,18 @@ <scope>test</scope> </dependency> </dependencies> + <profiles> + <profile> + <id>kudu-windows</id> Review comment: You might need to move the `kudu-binary` dependency into a profile for OSX and Linux so that Maven doesn't try to resolve it on Windows, which will result in a missing dependency. ex: ``` <profile> <id>kudu-linux</id> <activation> <os> <family>Unix</family> </os> </activation> <dependencies> <dependency> <groupId>org.apache.kudu</groupId> <artifactId>kudu-binary</artifactId> <version>${kudu.version}</version> <classifier>${os.detected.classifier}</classifier> <scope>test</scope> </dependency> </dependencies> </profile> <profile> <id>kudu-mac</id> <activation> <os> <family>mac</family> </os> </activation> <dependencies> <dependency> <groupId>org.apache.kudu</groupId> <artifactId>kudu-binary</artifactId> <version>${kudu.version}</version> <classifier>${os.detected.classifier}</classifier> <scope>test</scope> </dependency> </dependencies> </profile> ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services