bakaid commented on a change in pull request #650: MINIFICPP-1034 - MQTT 
processors doesnt work
URL: https://github.com/apache/nifi-minifi-cpp/pull/650#discussion_r326519579
 
 

 ##########
 File path: extensions/mqtt/processors/PublishMQTT.cpp
 ##########
 @@ -76,15 +67,15 @@ void PublishMQTT::onSchedule(core::ProcessContext 
*context, core::ProcessSession
 }
 
 void PublishMQTT::onTrigger(const std::shared_ptr<core::ProcessContext> 
&context, const std::shared_ptr<core::ProcessSession> &session) {
-  std::shared_ptr<core::FlowFile> flowFile = session->get();
-
-  if (!flowFile) {
+  if (!reconnect()) {
 
 Review comment:
   This way we reconnect even if there is no FlowFile to publish. I am not 
saying that it is necessarily a problem, but it changes the previous behaviour. 
Is this intentional?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to