arpadboda commented on a change in pull request #653: MINIFICPP-1033 -
PublishKafka fixes
URL: https://github.com/apache/nifi-minifi-cpp/pull/653#discussion_r327977788
##########
File path: extensions/librdkafka/PublishKafka.h
##########
@@ -100,89 +107,207 @@ class PublishKafka : public core::Processor {
static core::Relationship Failure;
static core::Relationship Success;
+ // Message
+ struct MessageResult {
+ bool completed;
Review comment:
As completed and error seem to be exclusive (at most one can be true), I
wonder if we can use an enum to indicate state in a more readable way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
