ijokarumawak commented on a change in pull request #3742: NIFI-6550: Create 
controller service for Azure Storage Credentials
URL: https://github.com/apache/nifi/pull/3742#discussion_r328709237
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
 ##########
 @@ -64,14 +64,21 @@
             .sensitive(true)
             .build();
 
+    public static final String ACCOUNT_NAME_BASE_DESCRIPTION =
+            "The storage account name.  There are certain risks in allowing 
the account name to be stored as a flowfile " +
+            "attribute. While it does provide for a more flexible flow by 
allowing the account name to " +
+            "be fetched dynamically from a flowfile attribute, care must be 
taken to restrict access to " +
+            "the event provenance data (e.g. by strictly controlling the 
policies governing provenance for this Processor). " +
+            "In addition, the provenance repositories may be put on encrypted 
disk partitions.";
+
     public static final PropertyDescriptor ACCOUNT_NAME = new 
PropertyDescriptor.Builder()
             .name("storage-account-name")
             .displayName("Storage Account Name")
-            .description("The storage account name.  There are certain risks 
in allowing the account name to be stored as a flowfile " +
-                    "attribute. While it does provide for a more flexible flow 
by allowing the account name to " +
-                    "be fetched dynamically from a flowfile attribute, care 
must be taken to restrict access to " +
-                    "the event provenance data (e.g. by strictly controlling 
the policies governing provenance for this Processor). " +
-                    "In addition, the provenance repositories may be put on 
encrypted disk partitions.")
+            .description(ACCOUNT_NAME_BASE_DESCRIPTION +
+                    " Instead of defining the Storage Account Name, Storage 
Account Key and SAS Token properties directly on the processor, " +
+                    "the preferred way is to configure them through a 
controller service specified in the Storage Credentials property. " +
+                    "The controller service can provide a common/shared 
configuration for multiple/all AWS processors. Furthermore, the credentials " +
 
 Review comment:
   I'll replace 'AWS' to 'Azure' when merging it :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to