phrocker commented on a change in pull request #648: WIP: Minificpp 1025 -- add
metadata
URL: https://github.com/apache/nifi-minifi-cpp/pull/648#discussion_r329141241
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -329,7 +404,14 @@ int ConsumeWindowsEventLog::processQueue(const
std::shared_ptr<core::ProcessSess
session->putAttribute(flowFile, FlowAttributeKey(MIME_TYPE),
"application/xml");
session->getProvenanceReporter()->receive(flowFile, provenanceUri_,
getUUIDStr(), "Consume windows event logs", 0);
session->transfer(flowFile, Success);
- session->commit();
+
+ flowFile = session->create();
+
+ session->write(flowFile, &WriteCallback(evt.rendered_text_));
+ session->putAttribute(flowFile, FlowAttributeKey(MIME_TYPE),
"text/plain");
+ session->getProvenanceReporter()->receive(flowFile, provenanceUri_,
getUUIDStr(), "Consume windows event logs", 0);
+ session->transfer(flowFile, Success);
Review comment:
I will add that I think @am-c-p-p is taking the reigns on this and he can
disagree, but we should be cognizant of creating confusion between java and cpp
variants. this I think yields the lowest confusion with allowing downstream
processors to split or take care of this. that is why roa exists.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
